New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RequestBuilder.submitAsync() throwing an Exception if the Glide request is restarted #4569

Merged

connyduck merged 1 commit into tuskyapp:develop from cbeyls:fix/glide_submitasync_3

Jul 14, 2024

Contributor

cbeyls commented Jul 12, 2024

This is the third attempt to fix RequestBuilder.submitAsync(). For the rationale, see the comments of #4436.

We now clear the continuation reference after resuming it, to make sure that:

It will only be resumed once
It will not leak the coroutine when Glide keeps the Request around.


          fix: clear the continuation reference after resuming it.

b172b08

connyduck approved these changes

View reviewed changes

connyduck merged commit 12040b9 into tuskyapp:develop

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet